I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

<

http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-l3sm-l3vpn-service-model-17.txt
Reviewer: Brian Carpenter
Review Date: 2016-10-21
IETF LC End Date: 2016-10-11
IESG Telechat date: 2016-10-27

Summary: Almost ready
--------

Comments:
---------

Thanks for responding to my LC comments. I have not checked the details of the yang.

Minor Issues:
-------------

This is a point I missed originally but I mentioned it during the discussion:
The model says:

      | | |   | | +--rw match-flow
      | | |   | |   +--rw dscp?        inet:dscp
      | | |   | |   +--rw tos?         uint8

but tos was obsoleted when dscp was defined by RFC 2474. I don't think
you should include tos. You don't mention ECN, which are the two bits
from tos that are not included in dscp. Those bits are no good for flow
matching because they are variable.  If an operator tries to use the 8 TOS
bits for flow matching but a user supports ECN, the matching will not work
consistently. So I think it's misleading to include this.